HDDS-11221. Resolve potential time discrepancy for expired multipart upload cleanup #6982
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kerneltime
reviewed
Jul 25, 2024
|
|
||
| final long expiredCreationTimestamp = | ||
| Instant.now().minus(expireThreshold).toEpochMilli(); | ||
| expireThreshold.negated().plusMillis(Time.now()).toMillis(); |
Contributor
There was a problem hiding this comment.
https://issues.apache.org/jira/browse/HDDS-7764 lists going to Time.now() as a temporary solution. We should switch to UTC time and not be dependent on local time zone configuration.
Contributor
Author
There was a problem hiding this comment.
Thank you for the review. I agree with switching from Time.now() to Instant.now() (which will be addressed in HDDS-7911). However, currently the issue is that OmKeyInfo creationTimestamp and modificationTimestamp already using Time.now(). If we switch to Instant.now() instead, the timestamps in the key / file table will be a mix of UTC and local time zone.
szetszwo
approved these changes
Jul 26, 2024
Contributor
szetszwo
left a comment
szetszwo
left a comment
There was a problem hiding this comment.
+1 the change looks good.
Contributor
Author
|
Thanks @kerneltime @szetszwo for the reviews. |
ivandika3
added a commit
to ivandika3/ozone
that referenced
this pull request
Oct 12, 2025
…upload cleanup (apache#6982) (cherry picked from commit dd831d8)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Similar to HDDS-7764, we need to update this to prevent expired multipart upload being cleaned up prematurely.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-11221
How was this patch tested?
Update existing unit tests.